Cleaning up unused code. #33499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tiagosampaio wants to merge 13 commits into magento:2.4-develop from tiagosampaio:2.4-develop-003

Member

tiagosampaio commented Jul 16, 2021 •

edited by m2-assistant bot

Loading

Cleaning up unused imports.

Description (*)

The intention of this PR is only to clean up the unused imports.

Related Pull Requests

Fixed Issues (if relevant)

This PR does not fix any issue.

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Cleaning up unused code. #38424: Cleaning up unused code.


          Cleaning up unused code.

ec91036

m2-assistant bot commented Jul 16, 2021

Hi @tiagosampaio. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

magento-engcom-team added Component: CatalogInventory Release Line: 2.4 labels

ihor-sviziev added Cleanup Risk: low Severity: S4 Type: Code Cleanup Auto-Tests: Not Required labels

Contributor

ihor-sviziev commented Jul 16, 2021

@magento run all tests

m2-community-project bot added the Progress: pending review label

magento-automated-testing bot commented Jul 16, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev self-assigned this

m2-community-project bot added Progress: review and removed Progress: pending review labels

Contributor

ihor-sviziev commented Jul 16, 2021

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests, WebAPI Tests

magento-automated-testing bot commented Jul 16, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Member Author

tiagosampaio commented Jul 16, 2021

@magento run Functional Tests B2B

magento-automated-testing bot commented Jul 16, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev approved these changes

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels

Contributor

magento-engcom-team commented Jul 16, 2021

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9151 has been created to process this Pull Request

Member Author

tiagosampaio commented Jul 16, 2021

@magento run Functional Tests B2B

magento-automated-testing bot commented Jul 16, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik approved these changes

View reviewed changes

m2-community-project bot assigned Den4ik

Contributor

Den4ik commented Jul 19, 2021

@magento run Functional Tests B2B

magento-automated-testing bot commented Jul 19, 2021

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Contributor

magento-engcom-team commented Jul 19, 2021

Hi @Den4ik, thank you for the review.
ENGCOM-9151 has been created to process this Pull Request

Contributor

engcom-Charlie commented Oct 28, 2024

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, Static Tests, WebAPI Tests

Contributor

engcom-Charlie commented Oct 28, 2024

Hi @tiagosampaio,

Thank you for the contribution!

By looking at the code, the changes looks good to me. No manual testing is required for now. We will check the build results further.

As the build is failing, moving this to Extended Testing.

Thank you!

Indrani Sonawane and others added 2 commits

November 12, 2024 12:57


          Fixed few static test failures

a45a0f5


          Merge branch '2.4-develop' into 2.4-develop-003

fd6cfa0

Contributor

engcom-Charlie commented Nov 12, 2024

@magento run all tests


          Merge branch '2.4-develop' into 2.4-develop-003

1a44b54

Contributor

engcom-Charlie commented Nov 26, 2024

@magento run all tests

Contributor

engcom-Charlie commented Nov 26, 2024

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests

Contributor

engcom-Charlie commented Nov 26, 2024

The Functional B2B failures in recent 2 builds are consistent and are known issues and not related to PR.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33499/3d8d4b5358ffacad130bf4f7c09ed585/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33499/3e00ad48637dbfdc1cf9df63bd842739/Functional/allure-report-b2b/index.html#categories/bf7275540687fa68090c04012bcd7e28/7ec06b0dc89e9a19/

Known issues:
ACQE-7230 - StorefrontReuseCouponCodeAfterOrderCanceledTest
ACQE-7229 - MultiShippingWithCreationNewCustomerAndAddressesDuringCheckoutTest

Contributor

engcom-Charlie commented Nov 26, 2024

One of the Functional CE failure in recent 2 builds is consistent and its a known issue. The failed tests are not related to PR.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33499/29dc970322b720af8f54405b1bd8fc81/Functional/allure-report-ce/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/33499/03be60d4c47ca381c91573ce71c1a1aa/Functional/allure-report-ce/index.html#categories/6d7e37752c3cc83cb3d2063131f608bb/e9195990b4e56205/

Known issues:
ACQE-7227 - VerifyDefaultWYSIWYGToolbarOnProductTest

engcom-Charlie added 2 commits

December 2, 2024 14:59


          Fixed static tests failures

a227f92


          Merge branch '2.4-develop-003' of https://github.com/tiagosampaio/mag…

a42d1eb

…ento2 into 2.4-develop-003

Contributor

engcom-Charlie commented Dec 2, 2024

@magento run all tests

1 similar comment

Contributor

engcom-Charlie commented Dec 2, 2024

@magento run all tests

magento-automated-testing bot commented Dec 2, 2024

Failed to run the builds. Please try to re-run them later.

Contributor

engcom-Charlie commented Dec 3, 2024

@magento run all tests

Contributor

engcom-Charlie commented Dec 4, 2024

@magento run Functional Tests B2B, Functional Tests CE, Static Tests

engcom-Charlie added 4 commits

December 6, 2024 18:44


          Update CreateDefaultStock.php

f83a270

Fixed static test


          Update UpdateStockItemsWebsite.php, fixed static tests

8dbc15f


          Update StockStatusCriteria.php, fixed static tests

316cee2


          Merge branch '2.4-develop' into 2.4-develop-003

3049fae

Contributor

engcom-Charlie commented Dec 6, 2024

@magento run all tests


          Update CreateDefaultStock.php, fixed static test

8012cb8

Contributor

engcom-Charlie commented Dec 9, 2024

@magento run all tests

engcom-Charlie requested review from ihor-sviziev and Den4ik

December 9, 2024 10:25

Contributor

engcom-Charlie commented Dec 9, 2024

@ihor-sviziev and @Den4ik I have made some fixes to take care static test failures. Kindly review the same.

Den4ik reviewed

View reviewed changes

Contributor

Den4ik left a comment

Hi @engcom-Charlie,

Thanks for update.
✅ All looks ok for me

ihor-sviziev removed their request for review

February 19, 2025 11:02

ihor-sviziev removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Not Required Cleanup Component: CatalogInventory Priority: P4 Progress: ready for testing Release Line: 2.4 Risk: low Severity: S4 Triage: Dev.Experience Type: Code Cleanup